Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sphinx): Support python 3.9 in Sphinx rules #2208

Merged

Conversation

imarban
Copy link
Contributor

@imarban imarban commented Sep 9, 2024

The implementation of the Sphinx related rules uses language features and types only available in python > 3.9. To the best of my understanding, rules_python aims to support python3.9 and therefore this patch uses typing-extensions instead of the built-in types.

After this change, one can use the sphinx_build_binary to create Sphinx docs using 3.9 runtime.

This fixes #2207

@rickeylev rickeylev added this pull request to the merge queue Sep 9, 2024
Merged via the queue into bazelbuild:main with commit acfc125 Sep 9, 2024
4 checks passed
@imarban imarban deleted the support-python39-sphinx-rules-main branch September 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx rules can't be used with Python 3.9
2 participants